Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile CLUA5* with SO lib target #31

Open
guyzmo opened this issue Feb 24, 2017 · 2 comments
Open

Compile CLUA5* with SO lib target #31

guyzmo opened this issue Feb 24, 2017 · 2 comments

Comments

@guyzmo
Copy link

guyzmo commented Feb 24, 2017

Hello, I'm using hererocks to test the embedded runtime integration in a program, and it's lacking the .so creation. Is there a way to make hererocks generate it? Or would it be possible to patch building of clua so it builds the shared library? As it's building the .so for luajit, it'd be a good idea to have it consistent across flavours.

@mpeterv
Copy link
Owner

mpeterv commented Feb 25, 2017

Hello, currently hererocks doesn't build .so for PUC-Rio Lua because neither does its standard Makefile, unlike LuaJIT. It should be possible to add it though. I don't know when I'll be able to look into it so patches are welcome (you'd want to add building the target to make method of RioLua class and add installing it to make_install method).

guyzmo added a commit to guyzmo/hererocks that referenced this issue Feb 25, 2017
- compiles lua with .so shared lib per default
- added --no-shared to skip building shared lib (and avoid -fPIC addition)

Fixes mpeterv#31

Signed-off-by: Guyzmo <[email protected]>
@guyzmo
Copy link
Author

guyzmo commented Feb 25, 2017

ok, done! Changing the makefile was useless (I tried that at first) because the make method doesn't care of what's happening in the makefile, so I ended up patching the make/make_install methods directly :)

guyzmo added a commit to guyzmo/hererocks that referenced this issue Mar 12, 2017
- compiles lua with .so shared lib per default
- added --no-shared to skip building shared lib (and avoid -fPIC addition)

Fixes mpeterv#31

Signed-off-by: Guyzmo <[email protected]>
guyzmo added a commit to guyzmo/hererocks that referenced this issue Mar 12, 2017
- compiles lua with .so shared lib per default
- added --shared to add building shared lib (and -fPIC addition)

Fixes mpeterv#31

Signed-off-by: Guyzmo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants