Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable exception handling when building WASM #1014

Open
marco-c opened this issue Jan 25, 2025 · 0 comments
Open

Disable exception handling when building WASM #1014

marco-c opened this issue Jan 25, 2025 · 0 comments
Labels
inference

Comments

@marco-c
Copy link
Collaborator

marco-c commented Jan 25, 2025

Adding -fno-exceptions should be useful according to https://emscripten.org/docs/optimizing/Optimizing-Code.html. However, currently spdlog uses exceptions. There's a SPDLOG_NO_EXCEPTIONS define we could use, but it is only available in recent versions of spdlog. We can update spdlog in Marian, and then we can disable exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
inference
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marco-c