Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer & nav hover decoration underlines only on last line #15850

Open
janbrasna opened this issue Jan 12, 2025 · 0 comments · May be fixed by #15855
Open

Footer & nav hover decoration underlines only on last line #15850

janbrasna opened this issue Jan 12, 2025 · 0 comments · May be fixed by #15855
Labels
Bug 🐛 Something's not working the way it should

Comments

@janbrasna
Copy link
Contributor

In languages or viewports that make some navigation links span across multiple lines, surprisingly only parts of the hovered anchor text get underlined:

Screen.Recording.2025-01-02.at.3.33.40.mov

The underline only decorating some of the lines makes it a bit puzzling for a moment, not being clear what words are actually part of what link etc.

This also happens in main menu when the items don't fit on one line:

Screenshot 2025-01-07 at 0 47 18

The underlines were coded this way to match the visual design assets provided, instead of the implicit style the typeface provides (or, doesn't) by itself.
(Not to be confused with #15683, that has the decoration animated, and has extra markup.)

@janbrasna janbrasna added the Bug 🐛 Something's not working the way it should label Jan 12, 2025
@janbrasna janbrasna linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant