-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delegate review actions to CinderActions #1982
Comments
Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-671 |
I looked over the main scenarios and some additional (with abuse reports attached) but I'm going to complete it later (noticed something and atm not sure how to interpret that so I'll re-test)
activity log at disable: More detailed testing: normal add-on disabled, email is sent, activity log registered ✅ recommended add-on disabled, "proceed with action" from 2nd level approval queue disabled the add-on and sends an email ✅ line add-on disabled, "proceed with action" from 2nd level approval queue disabled the add-on and sends an email ✅ spotlight add-on disabled ✅
notable add-on disabled, approve content instead -> does not send an email , content stays enabled ✅ |
Approving instead leads to a silent approval. To me this was intended, but I'm not sure whether the expected behavior was described anywhere, maybe it should be more explicit in the logs. Can you file a follow-up for this and we'll triage it ? Thanks. |
About 2nd level approvals with abuse reports:
Only after decision is taken in 2nd level approval queue the NHR and due date are cleared from the Manual Review Queue. -> It sounds like it should be the expected behavior but not 100% sure ❓ |
Currently we carry out the review actions of, for example, disabling an add-on by:
force_disable
This means we have duplicated places where we carry out the "disable addon" action, when for consistency it should be a single place.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: