Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about optional_permissions without optional_host_permissions / host_permissions #5329

Open
Rob--W opened this issue Jun 6, 2024 · 0 comments
Labels
component:MV3 Issues related to Manifest Version 3

Comments

@Rob--W
Copy link
Member

Rob--W commented Jun 6, 2024

Firefox 128 introduced support for optional_host_permissions (https://bugzilla.mozilla.org/show_bug.cgi?id=1766026), which removes the need for optional_permissions. Chrome does not support origins in optional_permissions. There may still be some value in the use of optional_permissions for backwards-compatibility with Firefox < 127 (such as Firefox ESR 115, which continues to be supported until October 1st, 2024).

We should check for the existence of origins in optional_permissions, and then verify whether it is present in optional_host_permissions (or host_permissions). If it is missing, it means that the permission won't be available in Chrome, or potentially in future versions of Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1897580). We should warn about that in this case, and recommend that the dev adds the origin to optional_host_permissions.

FYI: here is an analysis of public extensions that use origins in optional_permissions: https://bugzilla.mozilla.org/show_bug.cgi?id=1897580#c1

@Rob--W Rob--W added the component:MV3 Issues related to Manifest Version 3 label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:MV3 Issues related to Manifest Version 3
Projects
None yet
Development

No branches or pull requests

1 participant