Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-ext lint doesnt appear to check android min version #5223

Open
benmcgarry opened this issue Mar 12, 2024 · 0 comments
Open

web-ext lint doesnt appear to check android min version #5223

benmcgarry opened this issue Mar 12, 2024 · 0 comments

Comments

@benmcgarry
Copy link

benmcgarry commented Mar 12, 2024

Is this a feature request or a bug?

Bug

What is the current behavior?

From the manifest file, we are setting android as a minimum of 120, however the scanners defaulting to main browser and throwing an error. The API is supported as of 120: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/permissions/request

"browser_specific_settings": {
	"gecko": {
		"id": "jetpackidgoeshere",
		"strict_min_version": "115.0"
	},
	"gecko_android": {
		"strict_min_version": "120.0"
	}
},
WARNINGS 

permissions.request is not supported in Firefox for Android version 115.0

Warning: This API is not implemented by the given minimum Firefox for Android version

What is the expected or desired behavior?

Linter detects android min version and uses that for checks, this warning should not flag as the API is supported in the minimum defined version for Android. While the above error is technically correct, it shouldnt display if a compatible min android version is defined.

Version information (for bug reports)

  • Firefox version: Firefox 123.0.1
  • Your OS and version: Windows 11 23H2 22631.3296
  • Paste the output of these commands:
node --version && npm --version && web-ext --version

v21.6.2
10.2.4
7.11.0

┆Issue is synchronized with this Jira Task

@Rob--W Rob--W transferred this issue from mozilla/web-ext Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant