Sessions are closed after port-forwarded connection completes

[systemmonkey42]

Using the latest MASTER of SSHPortal, I noticed my client connections disconnected
randomly.

It turns out the session check in pkg/bastion/ssh.go calls "conn.close" within 30 seconds of a port-forward session completing. This consistently disconnected the client.

I've commented it out for now, since it isnt clear what it achieves (the pipe() handling has already closed the session afaict).

Is there a correct way to handle those? Port forwarding is a critical feature for me.

...

[libvoid]

This bug has been introduced in this commit you cherry-picked and is not present in the latest release of the original project (which is unmaintained btw)

We faced the same issue in our fork. The fix is here but we found out the feature was not working at all so I decided to completely remove the feature.

FYI, you should maybe consider rebasing your fork on our fork which is up to date and includes multiple security improvements / fixes. Keep in mind, our fork is on MAINTENANCE mode and only security issues and major bugs will be fixed. We don't plan to add and accept new features.

[systemmonkey42]

Hi @libvoid, Thanks for the tips. I'll let you know how I go.

Do you still use sshportal or is there an alternative you prefer?

EDIT: I saw in the Readme you clearly recommend Teleport. I've tried it a couple of times, but the infrastructure requirements for managing a single remote raspberry pi is a little excessive. When I get a second pi. I'll try again.

[systemmonkey42]

Hi @libvoid

It didn't take much testing to prove you were correct. Thanks for pointing me in the right direction.

[libvoid]

Hi,

Sorry for the late reply

Do you still use sshportal or is there an alternative you prefer?

We still use sshportal but we plan to change. Warpgate looks promising (:crab:) but Teleport is the only alternative that is not a one-person project.