Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading type annotation in Exchange.publish() #641

Open
epandurski opened this issue Jul 28, 2024 · 0 comments
Open

Misleading type annotation in Exchange.publish() #641

epandurski opened this issue Jul 28, 2024 · 0 comments

Comments

@epandurski
Copy link

The type annotation for the return value for the Exchange.publush() method is: Ack | Nack | Reject | None.

Looking at the implementation, it seems to me that if the publisher confirm is not "ack" the method raises an exception, not returning Nack, Reject, or None. Also, it seem to never return Ack either. If I am not mistaken, the annotation is very confusing, because it suggests that the return value must be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant