Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#+OPTIONS: toc:nil is ignored. #29

Open
UwUnyaa opened this issue Sep 8, 2018 · 2 comments
Open

#+OPTIONS: toc:nil is ignored. #29

UwUnyaa opened this issue Sep 8, 2018 · 2 comments

Comments

@UwUnyaa
Copy link

UwUnyaa commented Sep 8, 2018

Looking at code of this library, toc in options is expected to be a number, which is the level to which table of contents should be displayed. Hoverer, a value of nil is silently ignored, even though the org-mode manual lists toc:nil as a way to suppress displaying the table of contents. This breaks many org-mode documents, as official way to disable ToCs is ignored by this library.

@UwUnyaa UwUnyaa changed the title #+OPTIONS: toc:nil is ignored. #+OPTIONS: toc:nil is ignored. Sep 8, 2018
@UwUnyaa
Copy link
Author

UwUnyaa commented Sep 8, 2018

convertLispyValue seems to translate nil into false, but when I try to add a check for such value in computeToc to assign exportTocLevel to 0 (by the way, reassigning function argument values is very bad style), it ends up being ignored. I guess I can't make any sense of OOP spaghetti, and I can't provide a patch.

@jeansch
Copy link

jeansch commented Sep 13, 2018

Hi, it is supported (only for nil) in my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants