-
Notifications
You must be signed in to change notification settings - Fork 31
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use history.replaceState to change the URL when selecting modules in builder #183
Comments
If we md5-hash on client side how would we know if the that module-string already exists? The |
Yeah the hash will not be available to the server-side. You'd have to On Mon, Nov 17, 2014 at 3:30 PM, Sergio Crisostomo <[email protected]
|
You don't have to check whether it exists right? Just use the same md5 hashing as on the server-side. Only problem is when the user reloads or shares the page and the hash doesn't exist in the database... |
After #174 the builder creates build hashes again to quickly select all modules that were selected previously. It puts the link in the downloaded file.
Additionally we could use
history.pushState
andhistory.replaceState
to live update the URL with the hash, by md5 hashing the array of selected modules on the client-side.Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: