Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use history.replaceState to change the URL when selecting modules in builder #183

Open
arian opened this issue Nov 11, 2014 · 3 comments
Open
Milestone

Comments

@arian
Copy link
Member

arian commented Nov 11, 2014

After #174 the builder creates build hashes again to quickly select all modules that were selected previously. It puts the link in the downloaded file.

Additionally we could use history.pushState and history.replaceState to live update the URL with the hash, by md5 hashing the array of selected modules on the client-side.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@arian arian added this to the 1.2 milestone Nov 11, 2014
@timwienk timwienk changed the title Use history.replaceState to change the URL when selecting modules Use history.replaceState to change the URL when selecting modules in builder Nov 12, 2014
@SergioCrisostomo
Copy link
Member

If we md5-hash on client side how would we know if the that module-string already exists?

The app.post() is sending the file to client-side and I don't think/know that we can get the hash tag from there. Maybe a Request would be needed there? or what do you have in mind @arian ?

@ibolmo
Copy link
Member

ibolmo commented Nov 17, 2014

Yeah the hash will not be available to the server-side. You'd have to
include that in the request.

On Mon, Nov 17, 2014 at 3:30 PM, Sergio Crisostomo <[email protected]

wrote:

If we md5-hash on client side how would we know if the that module-string
already exists?

The app.post() is sending the file to client-side and I don't think/know
that we can get the hash tag from there. Maybe a Request would be needed
there? or what do you have in mind @arian https://github.com/arian ?


Reply to this email directly or view it on GitHub
#183 (comment).

@arian
Copy link
Member Author

arian commented Nov 18, 2014

You don't have to check whether it exists right? Just use the same md5 hashing as on the server-side.

Only problem is when the user reloads or shares the page and the hash doesn't exist in the database...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants