From 798a323c8a0522189a1209430881b1757af41156 Mon Sep 17 00:00:00 2001 From: Thibault Buathier Date: Thu, 18 Apr 2024 19:38:17 +0200 Subject: [PATCH] fix: ci error --- .github/workflows/ci.yml | 10 +++++----- src/Oro/ORM/Query/AST/FunctionFactory.php | 7 +++++-- tests/config/mysql.phpunit.xml | 4 ++-- tests/config/pgsql.phpunit.xml | 4 ++-- 4 files changed, 14 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0b6fb7e3d7..d2fdd25503 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,7 @@ name: CI on: [push, pull_request] jobs: - build: + test: runs-on: ubuntu-latest strategy: matrix: @@ -21,7 +21,7 @@ jobs: db: mysql vars: '-e MYSQL_PASSWORD=travis -e MYSQL_DATABASE=doctrine_extensions_tests -e MYSQL_USER=travis -e MYSQL_ROOT_PASSWORD=travis' db_port: 3306 - health: '--health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=10s --health-retries=10' + health: '--health-cmd="healthcheck.sh --connect --innodb_initialized" --health-interval=10s --health-timeout=5s --health-retries=3' - db_image_name: percona db_image_version: 8 db: mysql @@ -30,16 +30,16 @@ jobs: health: '--health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=10s --health-retries=10' - db_image_name: postgres db_image_version: 15 - db: mysql + db: pgsql vars: '-e POSTGRES_DB=doctrine_extensions_tests -e POSTGRES_USER=travis -e POSTGRES_PASSWORD=travis' health: '--health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5' db_port: 5432 services: database: - image: ${{ matrix.db_image }} + image: ${{ matrix.db_image_name }}:${{ matrix.db_image_version }} ports: - - ${{ matrix.db_port }}:{{ matrix.db_port }} + - ${{ matrix.db_port }}:${{ matrix.db_port }} options: >- ${{ matrix.vars }} ${{ matrix.health }} diff --git a/src/Oro/ORM/Query/AST/FunctionFactory.php b/src/Oro/ORM/Query/AST/FunctionFactory.php index cbf62562f1..ca8bef268b 100644 --- a/src/Oro/ORM/Query/AST/FunctionFactory.php +++ b/src/Oro/ORM/Query/AST/FunctionFactory.php @@ -16,8 +16,11 @@ class FunctionFactory * * @throws QueryException */ - public static function create(AbstractPlatform $platform, string $functionName, array $parameters): PlatformFunctionNode - { + public static function create( + AbstractPlatform $platform, + string $functionName, + array $parameters + ): PlatformFunctionNode { if ($platform instanceof PostgreSQLPlatform) { $platformName = 'postgresql'; } elseif ($platform instanceof MySQLPlatform) { diff --git a/tests/config/mysql.phpunit.xml b/tests/config/mysql.phpunit.xml index 5ed9c52774..5840cd4248 100644 --- a/tests/config/mysql.phpunit.xml +++ b/tests/config/mysql.phpunit.xml @@ -2,11 +2,11 @@ - + - + diff --git a/tests/config/pgsql.phpunit.xml b/tests/config/pgsql.phpunit.xml index 2786537d39..26f2b83d3d 100644 --- a/tests/config/pgsql.phpunit.xml +++ b/tests/config/pgsql.phpunit.xml @@ -2,11 +2,11 @@ - + - +