Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdfilereader include associated data items #106

Closed
timoleistner opened this issue Feb 5, 2024 · 2 comments
Closed

sdfilereader include associated data items #106

timoleistner opened this issue Feb 5, 2024 · 2 comments

Comments

@timoleistner
Copy link

It would be nice to use one of SDFiles key features and include the associated data to the molfile.
More often than not, some internal ID or molecular properties are also included in the SDFile.
Could be as simple as including a properties dict to the MolGraph struct and parsing the associated data items into this.

@timoleistner
Copy link
Author

timoleistner commented Feb 5, 2024

Just noticed there is metadata() which does exactly what I want. It's not in the docs, but in the corresponding "how to use" pluto notebooks. Could be worth to also include it in the official docs :)

@mojaie
Copy link
Owner

mojaie commented Feb 25, 2024

Thank you very much for the comment. Yes, this should be documented.
Please note that metadata is still incomplete and may not work with SMILES, and the interface would change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants