Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rviz Markers aren't lit by rviz_lighting lights #2

Open
lucasw opened this issue Sep 4, 2017 · 2 comments
Open

rviz Markers aren't lit by rviz_lighting lights #2

lucasw opened this issue Sep 4, 2017 · 2 comments

Comments

@lucasw
Copy link

lucasw commented Sep 4, 2017

This is probably more an issue for rviz, the solution could go into a follow up to your ros-visualization/rviz#1146

I've tried CUBE_LIST and SPHERE_LIST and it looks like they use a different hard-coded light rather than the head light, it would be nice to be able to light them like any other geometry. Haven't tried other marker types yet but I will follow up.

@mogumbo
Copy link
Owner

mogumbo commented Sep 4, 2017

In a sane world, this should be as easy as enabling GL_LIGHTING when the markers are drawn.

It would be nice if Markers had a "receive light" flag because I sort of like giving them the glowy look (brightly colored and partly transparent without any lighting).

@lucasw
Copy link
Author

lucasw commented Sep 5, 2017

It looks like the Marker spheres (and cubes, cones, and cylinders) are binary Ogre .mesh objects in the /rviz/ogre_media/models folder- they mostly aren't readable the first two lines are:

^@^P[MeshSerializer_v1.8]
^@0Ï^V^@^@^@^@@<8c>^L^@^@BaseWhiteNoLighting

I wonder if they have lighting baked in, and nothing in the rviz code is going to change they way they look (except color still works). I haven't looked too far but there weren't any setLightingEnabled calls in the marker code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants