Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal and Finder tabs are detected as unique windows and tiled with gaps #39

Open
mogenson opened this issue Mar 15, 2024 · 7 comments

Comments

@mogenson
Copy link
Owner

Open a new tab in a Terminal or Finder window (may also occur in other applications). That window will be moved right the width of the window. This is because we are detecting the new tab as a unique window with a width of the original window.

Figure out how to detect when a window is a tab and ignore it. Maybe compare window ID with the window list?

@mogenson
Copy link
Owner Author

Being worked on in #41

@mogenson
Copy link
Owner Author

Blocked by issues:
Hammerspoon/hammerspoon#3625
and
Hammerspoon/hammerspoon#3626

@tshort
Copy link

tshort commented Aug 26, 2024

The MS-Office suite of programs seems to be caught by the tab warning. That's surprising given that I don't see any tabs in these programs.

I had to disable the tab check for this spoon to be usable at all. I don't use tabs in Finder much, so this is an easy solution for me.

@mogenson
Copy link
Owner Author

@tshort That's a shame to hear. There's no good way for PaperWM.spoon to determine whether a tab is a "real" tab or part of a larger window, like it seems MS Office is doing.

How about either a global config to enable/disable the unsupported tab warning or a window filter override to disable the warning per application?

@bestguy
Copy link

bestguy commented Sep 16, 2024

Just an FYI, the behavior seems "better" in the newly released macOS 15 Sequoia and hammerspoon 1.0 - at least from when I last tried this. I don't want to imply everything works perfectly now, but I'm not seeing the extra gaps when there are tabs.

@mogenson
Copy link
Owner Author

Great! Good to close this issue then?

@bestguy
Copy link

bestguy commented Sep 17, 2024

Actually, my apologies - if you remove the check for if add_window:tabCount() > 0 then here you actually do still see the gaps. I was confusing the check exiting early with gaps being fixed. I think you should leave this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants