Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS in QuipReply in website parameter, and Quip CMP gets Blocked #10

Open
AlbertoCarrasco opened this issue Jun 4, 2014 · 0 comments
Open

Comments

@AlbertoCarrasco
Copy link

When writing a new comment in QuipReply, you can put javascript code inside website placeholder. Example:

javascript:alert('XSS')

Proof of Concept:
image

If email parameter is set as taken as the "href" property for an <a> tag (as by default), then it will turn into XSS:

quipcomment.chunk.tpl - line 8:

<span class="quip-comment-author">[[+authorName]]:</span><br />

If "website" field is not empty in a comment, [[+authorName]] generates automatically an <a> tag with "website" as the content of "href" property, without any chances to filter the "href" parameter by ourselves.

Besides this, if any comment has XSS, when you try to manage a thread with the Quip CMP, the table of comments is empty. If you clean in the database the harmful comments, everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant