Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0: deploy examples to github pages. #57

Open
husayt opened this issue Aug 15, 2024 · 9 comments
Open

v1.0.0: deploy examples to github pages. #57

husayt opened this issue Aug 15, 2024 · 9 comments
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@husayt
Copy link
Contributor

husayt commented Aug 15, 2024

@gioboa will be very useful to add extra steps to our github action to deploy examples to github pages.

This article covers it:
https://javascript.plainenglish.io/deploying-a-vite-app-to-github-pages-using-github-actions-a-step-by-step-guide-ff63d93e4da2

we just need to repeat it twice. Once for host and once for remote.

@gioboa
Copy link
Collaborator

gioboa commented Aug 15, 2024

I can deploy the examples on my CloudFlare account too. I'm wondering if it is better to have these examples in the main repo with all the other module-federation examples

@husayt
Copy link
Contributor Author

husayt commented Aug 15, 2024 via email

@gioboa gioboa changed the title Deploy examples to github pages. new-config: deploy examples to github pages. Aug 16, 2024
@gioboa gioboa changed the title new-config: deploy examples to github pages. v1.0.0: deploy examples to github pages. Aug 16, 2024
@gioboa
Copy link
Collaborator

gioboa commented Sep 26, 2024

@husayt what are the benefits to have the examples online?

@husayt
Copy link
Contributor Author

husayt commented Sep 26, 2024

they are easy to deploy, and since they are static bundles, no node server is needed. the benefit is that they will help a lot to understand what this project does. Otherwise, one has to check out, install, and run locally just to try them. Examples are also playing the role of the documentation for us currently

btw, @gioboa, great article you posted on this effort, and thanks for mentioning me. Seems you did not have my name and just put username. It's Huseyn Guliyev if you want to have a full name there.

@gioboa
Copy link
Collaborator

gioboa commented Sep 26, 2024

Yep, thanks 😂
I think it's time consuming to maintain all the examples with a high quality. we can grab few screenshots for all of them and deploy the most complicated and complete one. With this approach we will reduce the effort in long term.

@husayt
Copy link
Contributor Author

husayt commented Sep 26, 2024

Absolutely, one deployed example will be enough at this stage

@gioboa gioboa added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it labels Sep 26, 2024
@gioboa
Copy link
Collaborator

gioboa commented Sep 26, 2024

Let's deploy the multi bundle one 👍

@Symyon
Copy link

Symyon commented Nov 3, 2024

Do you have anything deployed yet? I can't for the life of me make this work in a deployed app, it would be nice to have an app that works deployed and code for it, so we can just compare what's different.

@Symyon
Copy link

Symyon commented Nov 4, 2024

Found an example that will actually run from the built assets folder, it's the official one as well, so my bad I didn't start with it:
https://github.com/gioboa/react-microfrontend-demo?tab=readme-ov-file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants