-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0: deploy examples to github pages. #57
Comments
I can deploy the examples on my CloudFlare account too. I'm wondering if it is better to have these examples in the main repo with all the other module-federation examples |
probably best is to keep here, as thanks to you it is easier to maintain them.
If you want, we can have examples folder in main repo with symlinks to here.
…On Thu, 15 Aug 2024, 13:06 Giorgio Boa, ***@***.***> wrote:
I can deploy the examples on my CloudFlare account too. I'm wondering if
it is better to have these examples in the main repo with all the other
module-federation examples
—
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI5PLBW6AFX5Y33VCGWVIDZRSKWDAVCNFSM6AAAAABMSCLAQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGE2TAOBXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@husayt what are the benefits to have the examples online? |
they are easy to deploy, and since they are static bundles, no node server is needed. the benefit is that they will help a lot to understand what this project does. Otherwise, one has to check out, install, and run locally just to try them. Examples are also playing the role of the documentation for us currently btw, @gioboa, great article you posted on this effort, and thanks for mentioning me. Seems you did not have my name and just put username. It's Huseyn Guliyev if you want to have a full name there. |
Yep, thanks 😂 |
Absolutely, one deployed example will be enough at this stage |
Let's deploy the multi bundle one 👍 |
Do you have anything deployed yet? I can't for the life of me make this work in a deployed app, it would be nice to have an app that works deployed and code for it, so we can just compare what's different. |
Found an example that will actually run from the built assets folder, it's the official one as well, so my bad I didn't start with it: |
@gioboa will be very useful to add extra steps to our github action to deploy examples to github pages.
This article covers it:
https://javascript.plainenglish.io/deploying-a-vite-app-to-github-pages-using-github-actions-a-step-by-step-guide-ff63d93e4da2
we just need to repeat it twice. Once for host and once for remote.
The text was updated successfully, but these errors were encountered: