Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DictEntry.reap_value for new out syntax #3884

Closed
1 task done
christoph-schlumpf opened this issue Dec 14, 2024 · 1 comment
Closed
1 task done

Refactor DictEntry.reap_value for new out syntax #3884

christoph-schlumpf opened this issue Dec 14, 2024 · 1 comment
Labels
enhancement New feature or request mojo Issues that are related to mojo mojo-repo Tag all issues with this label

Comments

@christoph-schlumpf
Copy link

christoph-schlumpf commented Dec 14, 2024 •
edited
Loading

Review Mojo's priorities

What is your request?

Shouldn‘t DictEntry.reap_value be refactored?

From
fn reap_value(owned self) -> V as out:
to
fn reap_value(owned self, out result: V):

https://github.com/modularml/mojo/blob/c05884d66f25db0d5c29b3b7ca8248d6a306f6f5/stdlib/src/collections/dict.mojo#L247

What is your motivation for this change?

Conformance to new out syntax as described in #3623

Any other details?

No response
@christoph-schlumpf christoph-schlumpf added enhancement New feature or request mojo-repo Tag all issues with this label labels Dec 14, 2024
@christoph-schlumpf
Copy link
Author

This Issue can be closed as the change is already done.

@ematejska ematejska added the mojo Issues that are related to mojo label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request mojo Issues that are related to mojo mojo-repo Tag all issues with this label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christoph-schlumpf @ematejska