You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When extracting a tinyint field with value 0, the line is not included in the YAML file. I think this happens with other 0 / empty values too, so that's not necessarily the problem.. But in this case, the value is not being (re)set to 0 on build.
Step to reproduce
Login to a MODX install with Gitify configured and at least 1 plugin.
diff --git a/_data/plugins/ClientConfig.php b/_data/plugins/ClientConfig.php
index a51d7db..dd5e904 100644
--- a/_data/plugins/ClientConfig.php
+++ b/_data/plugins/ClientConfig.php
@@ -1,7 +1,8 @@
id: 100013
name: ClientConfig
description: 'Sets system settings from the Client Config CMP.'
-properties: null
+properties: 'a:0:{}'
+disabled: 1
Now, either reset the YAML file or enable the plugin again in MODX, extract, and then disable again. The disabled line is now removed from the extract again.
Observed behavior
Build and behold: the plugin is still disabled!
I'm currently experiencing this with multiple fields, mostly in custom tables. All are tinyint.
In the SQL schema, the fields often have a default value of 0. Maybe that's why they're not being extracted?
Summary
When extracting a tinyint field with value 0, the line is not included in the YAML file. I think this happens with other 0 / empty values too, so that's not necessarily the problem.. But in this case, the value is not being (re)set to 0 on build.
Step to reproduce
You should see the added line for disabled:
Now, either reset the YAML file or enable the plugin again in MODX, extract, and then disable again. The disabled line is now removed from the extract again.
Observed behavior
Build and behold: the plugin is still disabled!
I'm currently experiencing this with multiple fields, mostly in custom tables. All are tinyint.
In the SQL schema, the fields often have a default value of 0. Maybe that's why they're not being extracted?
Expected behavior
The plugin should be enabled again, as
disabled: 1
is no longer present.Environment
Gitify 2.0.0-alpha3
MODX 2.8.4
MariaDB 10.6
PHP 8.1
The text was updated successfully, but these errors were encountered: