Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspect and remove unnecessary code handling MCMP #278

Closed
jajik opened this issue Sep 10, 2024 · 2 comments · Fixed by #281
Closed

Inspect and remove unnecessary code handling MCMP #278

jajik opened this issue Sep 10, 2024 · 2 comments · Fixed by #281
Assignees
@jajik
Labels
enhancement

Comments

@jajik
Copy link
Collaborator

jajik commented Sep 10, 2024 •
edited
Loading

  1. decide whether checks in process_context_alias are needed when the conditions are checked afterwards
  2. are (/can) these checks even correct?
  3. is CONFIG with only one from Alias/Context valid? (imho it should be, but the code seems to imply otherwise in some places – e.g. process_context_alias with config)
@jajik jajik self-assigned this Sep 10, 2024
@jajik
Copy link
Collaborator Author

jajik commented Sep 13, 2024

Ad 3. it is valid for both 1.3.x and 2.x currently

@jajik
Copy link
Collaborator Author

jajik commented Sep 13, 2024

Ad 1. and 2., no, it will be addressed in a PR soon

@jajik jajik mentioned this issue Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jajik jajik

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify and fix CONFIG parameters handling jajik/mod_proxy_cluster
1 participant
@jajik