Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite: integrate a proper testing framework rather than using set of custom scripts #130

Closed
rhusar opened this issue Aug 10, 2023 · 7 comments · Fixed by #283
Closed
Assignees

Comments

@rhusar
Copy link
Member

rhusar commented Aug 10, 2023

e.g. use bats.

@jajik
Copy link
Collaborator

jajik commented Aug 10, 2023

Just to mention, the current testsuite tries to be POSIX compliant, which bats is not (?). We might consider ShellSpec, which should be.

However, I don't know any of these, so I'll have a look and will report about it.

@rhusar
Copy link
Member Author

rhusar commented Aug 10, 2023

@jajik When you have a minute, if you can look into what upstream Apache and / or it's modules use that would be interesting too. I am going to just assume it's something home brewed and not portable.

@jajik
Copy link
Collaborator

jajik commented Aug 10, 2023

That's a good idea. Will do.

@jajik jajik self-assigned this Aug 11, 2023
@jajik
Copy link
Collaborator

jajik commented Sep 22, 2023

So, it turns out that httpd uses (maybe a bit surprisingly) pytest for some testing (see README.pytest). That looks interesting, although I don't like python very much. Personally, I don't think rewriting tests we have into pytest is the way to go, I would prefer just adapting them to ShellSpec/bats, but for new tests it might be an option.

@rhusar
Copy link
Member Author

rhusar commented Sep 22, 2023

So, it turns out that httpd uses (maybe a bit surprisingly) pytest for some testing (see README.pytest). That looks interesting, although I don't like python very much. Personally, I don't think rewriting tests we have into pytest is the way to go, I would prefer just adapting them to ShellSpec/bats, but for new tests it might be an option.

If we are talking about preferences I would strongly to prefer to have them in Java. I am under impression that what we have now can be done in Java quite with ease. I was under impression that the rewriting of the testsuite was with the idea to be in line with httpd apache project. Anyway, I will try to kick off some more discussions.

@jfclere
Copy link
Member

jfclere commented Nov 1, 2023

https://github.com/apache/httpd-tests is the one I contributed.

@jajik
Copy link
Collaborator

jajik commented Nov 1, 2023

That looks like Perl! Definitely prefer that over Python, I'll have a look, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants