Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing empty directories doesn't work #147

Open
talex5 opened this issue Jun 9, 2016 · 2 comments
Open

Removing empty directories doesn't work #147

talex5 opened this issue Jun 9, 2016 · 2 comments

Comments

@talex5
Copy link
Contributor

talex5 commented Jun 9, 2016

Because Git doesn't store empty directories, mkdir in a transaction's rw directory doesn't change the tree. However, because we do want the new directory to appear in ls listings we add it to extra_dirs.

However, when we remove a directory we don't delete it from its parent's extra_dirs and it still appears in the ls output.

@samoht
Copy link
Member

samoht commented Jul 18, 2016

I've just hit that and it is a bit surprising :-)

@samoht
Copy link
Member

samoht commented Aug 31, 2016

@talex5 any chance you could have a look at it? It makes some stuff in the bridge a bit tricky..

avsm pushed a commit to avsm/datakit that referenced this issue Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants