Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project recreates scriptable object when the project is pulled from git #200

Closed
oktayturkdagli opened this issue Sep 20, 2024 · 9 comments
Closed

Project recreates scriptable object when the project is pulled from git #200

oktayturkdagli opened this issue Sep 20, 2024 · 9 comments
Assignees
@mob-sakai
Labels
bug Something isn't working released

Comments

@oktayturkdagli
Copy link

Describe the bug
When a new project is created and sent to git and then the project is pulled by someone else, the asset in the project settings folder appears as a white file in Unity and Unity does not recognize this file, the soft mask creates a new asset. So we have two assets but only one of them works.

To Reproduce
I have not tried to reproduce it, I can provide more information about it later. But I think it should be like this:
Both sides have pulled the project once. Then one of the users changes the motion sensitivity to High on the asset and pushes it. The person on the other side pulls and sees that their asset is damaged and a new asset is created.

Environment:
Version: 2.3.7
Platform: Mac
Unity version: Unity 2022.3.45
Build options: [ IL2CPP, .Net 4.x, URP, Android(API 33)]
@oktayturkdagli oktayturkdagli added the bug Something isn't working label Sep 20, 2024
@mob-sakai
Copy link
Owner

Thank you for your reporting!
Indeed, an exception occurred immediately after the package installation.

mob-sakai added a commit that referenced this issue Sep 21, 2024
@mob-sakai
fix: recreates ProjectSettings scriptable object when the project is …
9f6ea22 
…pulled from GitHub

close #200
@mob-sakai
Copy link
Owner

@oktayturkdagli
Please try RC version.

"com.coffee.softmask-for-ugui": "https://github.com/mob-sakai/SoftMaskForUGUI.git?path=Packages/src#develop",

@oktayturkdagli
Copy link
Author

Great! I'll try on Monday. 🙏

@oktayturkdagli
Copy link
Author

There doesn't seem to be a problem here, but I haven't tested it in detail. I can do detailed tests after the release.

@oktayturkdagli oktayturkdagli changed the title Recreates ProjectSettings scriptable object when the project is pulled from GitHub Project Recreates scriptable object when the project is pulled from GitHub Sep 23, 2024
@oktayturkdagli oktayturkdagli changed the title Project Recreates scriptable object when the project is pulled from GitHub Project recreates scriptable object when the project is pulled from GitHub Sep 23, 2024
@oktayturkdagli oktayturkdagli changed the title Project recreates scriptable object when the project is pulled from GitHub Project recreates scriptable object when the project is pulled from git Sep 23, 2024
github-actions bot pushed a commit that referenced this issue Sep 29, 2024
@semantic-release-bot
chore(release): 2.3.8 [skip ci]
16cc274 
## [2.3.8](v2.3.7...v2.3.8) (2024-09-29)

### Bug Fixes

* if `UniversalRenderPipelineAsset.renderScale` is not 1, soft masking will not be rendered correctly ([6e5a7f9](6e5a7f9)), closes [#194](#194)
* in URP, dynamic resolution does not work when render scale is close to 1 ([afed40a](afed40a))
* recreates ProjectSettings scriptable object when the project is pulled from GitHub ([9f6ea22](9f6ea22)), closes [#200](#200)
* when using dynamic resolution, soft masking will not be rendered correctly ([5100e3f](5100e3f)), closes [#199](#199)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 2.3.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Sep 29, 2024
@mob-sakai
fix: recreates ProjectSettings scriptable object when the project is …
52a89be 
…pulled from GitHub

close #200
github-actions bot pushed a commit that referenced this issue Sep 29, 2024
@semantic-release-bot
chore(release): 2.3.8 [skip ci]
20a581b 
## [2.3.8](v2.3.7...v2.3.8) (2024-09-29)

### Bug Fixes

* if `UniversalRenderPipelineAsset.renderScale` is not 1, soft masking will not be rendered correctly ([6e5a7f9](6e5a7f9)), closes [#194](#194)
* in URP, dynamic resolution does not work when render scale is close to 1 ([afed40a](afed40a))
* recreates ProjectSettings scriptable object when the project is pulled from GitHub ([9f6ea22](9f6ea22)), closes [#200](#200)
* when using dynamic resolution, soft masking will not be rendered correctly ([5100e3f](5100e3f)), closes [#199](#199)
@Mepkatatsu
Copy link

I experienced the same issue in version 2.3.8. I'm not sure of the exact cause(I had moved the package to a different path when I first import it.), it seemed that every time I pulled from Git or restarted the project, the UISoftMask.asset was always newly generated, but it wasn't properly registered to the Preloaded Assets. So I manually registered it to Preloaded Assets, and the issue was resolved.

@mob-sakai mob-sakai reopened this Nov 13, 2024
@oktayturkdagli
Copy link
Author

oktayturkdagli commented Nov 13, 2024 •
edited
Loading

By the way, I don't have this problem. We did not have such a problem after the patch. We use v2.4.0.

mob-sakai added a commit that referenced this issue Nov 13, 2024
@mob-sakai
fix: If not configured as a preloaded asset, the project settings ass…
cca61d7 
…et will be regenerated

close #200, close #212
@mob-sakai
Copy link
Owner

If it is not configured as a preloaded asset, the project settings asset will be regenerated.
Also, since generating assets in the InitializedOnLoadMethod event is not ideal, I’ll generate them in the OnPostprocessAllAssets event.

github-actions bot pushed a commit that referenced this issue Nov 14, 2024
@semantic-release-bot
chore(release): 2.4.1 [skip ci]
a4d55b7 
## [2.4.1](v2.4.0...v2.4.1) (2024-11-14)

### Bug Fixes

* alpha hit test not working in demo scene ([135b123](135b123)), closes [#210](#210)
* If not configured as a preloaded asset, the project settings asset will be regenerated ([cca61d7](cca61d7)), closes [#200](#200) [#212](#212)
* SoftMaskable is not editable ([f9937a9](f9937a9))
* TerminalMaskingShape is hidden even with `HideGeneratedComponents=false` ([8ddb586](8ddb586))
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Nov 14, 2024
@mob-sakai
fix: If not configured as a preloaded asset, the project settings ass…
fdc8976 
…et will be regenerated

close #200, close #212
github-actions bot pushed a commit that referenced this issue Nov 14, 2024
@semantic-release-bot
chore(release): 2.4.1 [skip ci]
038087c 
## [2.4.1](v2.4.0...v2.4.1) (2024-11-14)

### Bug Fixes

* alpha hit test not working in demo scene ([135b123](135b123)), closes [#210](#210)
* If not configured as a preloaded asset, the project settings asset will be regenerated ([cca61d7](cca61d7)), closes [#200](#200) [#212](#212)
* SoftMaskable is not editable ([f9937a9](f9937a9))
* TerminalMaskingShape is hidden even with `HideGeneratedComponents=false` ([8ddb586](8ddb586))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mob-sakai mob-sakai

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mob-sakai @oktayturkdagli @Mepkatatsu