Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/addchain,internal/gen: allow input parameters #128

Open
mmcloughlin opened this issue Oct 27, 2021 · 0 comments
Open

cmd/addchain,internal/gen: allow input parameters #128

mmcloughlin opened this issue Oct 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@mmcloughlin
Copy link
Owner

Initial code generation support #94 #127 has landed but has some limitations, the most notable of which is that variable names are hard-coded:

// Prepare template data.
cfg := gen.Config{
Allocator: pass.Allocator{
Input: "x",
Output: "z",
Format: "t%d",
},
}

At a minimum these should be configurable.

It may also make sense to support additional input parameters that are passed on to the template. For example, in the code generation case you might want things like the function name or package name to be configurable so that one template could be shared.

@mmcloughlin mmcloughlin added the enhancement New feature or request label Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant