Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how locales and prompt file name interact with each other #781

Open
rogthefrog opened this issue Jan 7, 2025 · 0 comments
Open
Assignees

Comments

@rogthefrog
Copy link
Contributor

The safe test downloads prompt files from modellab. It supports multiple locales in a given file, but doesn't do well with different files for different locales.

Workarounds exist, but they're hacky.

Options:

  • Improve file naming conventions to support locales. Proposal: if a file includes one locale, include that locale in the filename. English prompt files don't include en_us and that makes the code messy.
  • Ensure that we don't try to make test items in locale X using a file that does not include locale X (e.g. in the smoke test).
  • Handle file not found errors better, especially in unit or smoke tests.
  • If any unit tests rely on downloading an asset from modellab, replace that with a local file.

References:

Workaround for test items

Workaround for filenames with and without locales

@rogthefrog rogthefrog changed the title Improve how locals and prompt file name interact with each other Improve how locales and prompt file name interact with each other Jan 7, 2025
@rogthefrog rogthefrog self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant