hang with request interception + ignoreHTTPSErrors

[rymdhund]

This hangs:

import asyncio
from pyppeteer import launch

async def request_async():
    browser = await launch(
        ignoreHTTPSErrors=True,
        args=['--no-sandbox'],
    )

    async def handle_request(request):
        return await request.continue_()

    page = await browser.newPage()

    await page.setRequestInterception(True)
    page.on('request', lambda req: asyncio.ensure_future(handle_request(req)))

    resp = await page.goto("https://expired.badssl.com/")

loop = asyncio.get_event_loop()
loop.run_until_complete(request_async())

The same puppeteer issue: puppeteer/puppeteer#1159

Possibly related to #69?

Root cause seems to be upstream bug in chromium. Fixed in chromium r588429

Can we update the chromium version?

[miyakogi]

In order to update chromium, we need to change network_manager.py (puppeteer/puppeteer@1931cb4).
I will try to port this patch tomorrow.

[rymdhund]

I see! Thanks for the good work!

[miyakogi]

Updated chromium to r588429 on dev branch.

[rymdhund]

Yes it works now!

[miyakogi]

This is an issue tracker for pyppeteer (python fork of puppeteer), not for puppeteer's.
Puppeteer's issue tracker is here.

[phuang0619]

my apologies