Move track commands #678
Move track commands #678
Conversation
|
|
||
| .. versionadded:: 2.5.0 | ||
|
|
||
|
|
There was a problem hiding this comment.
Note that the controls seem to be ordered alphabetically, but actually it's better to have them grouped by 'function'/effect. Please move the block down so MoveVertical is below MoveUp again.
There was a problem hiding this comment.
Oh sure, I didn''t realize it was related
| @@ -3174,6 +3174,26 @@ Note that :mixxx:coref:`[Library],MoveUp` and other Move and Scroll controls emu | |||
| .. versionadded:: 2.1.0 | |||
|
|
|||
|
|
|||
| .. mixxx:control:: [Library],MoveTrackUp | |||
|
|
|||
| Equivalent to pressing the :kbd:`Alt` + :kbd:`Up` key on the keyboard | |||
There was a problem hiding this comment.
I'm not sure everyone browsing these controls is aware of the new Alt move feature.
I suggest to add more context here in order to make this feature more discoverable.
For example:
Move the track selection up by one row. This is applicable only in (unlocked) Playlists.
Same for down and MoveTrack.
There was a problem hiding this comment.
I reworded a bit both texts, what do you think?
| Equivalent to pressing the :kbd:`Alt` + :kbd:`Up` key on the keyboard | ||
|
|
||
| :range: Binary | ||
| :feedback: Move selected track up |
There was a problem hiding this comment.
or put it here (but maybe the explanation is to much for the 'feedback' hint):
Track selection is moved up by one row
What do you think?
There was a problem hiding this comment.
I reworded it so it's a bit more like other entries
|
Thanks, looks good. Did you accidentally remove |
I had not added it at first, it's there now. |
|
|
||
| Move track selection up or down by one row in the playlist. Equivalent to pressing the :kbd:`Alt` + :kbd:`Up` or :kbd:`Alt` + :kbd:`Down` key on the keyboard. This is applicable only in unlocked playlists. | ||
|
|
||
| :range: Binary |
There was a problem hiding this comment.
This should actually be integer (move by n rows), but I just noticed that this optional factor is not considered in WLibraryTableView::moveCursor().
I've just filed mixxxdj/mixxx#13398
Documenting commands from mixxxdj/mixxx#13098 (comment)
Preview:
https://deploy-preview-678--mixxx-manual.netlify.app/chapters/appendix/mixxx_controls#control-[Library]-MoveTrackUp