Traktor S4MK3: Language fixes #652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywwg
changed the title
|
@acolombier please review (github won't let me add you) |
acolombier
reviewed
May 8, 2024
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Outdated
Show resolved
Hide resolved
source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst
Outdated
Show resolved
Hide resolved
acolombier
reviewed
May 9, 2024
|
|
||
| - `Manufacturer’s product page <https://www.native-instruments.com/en/products/traktor/dj-controllers/traktor-kontrol-s4/>`__ | ||
| - `Manufacturer's product page <https://www.native-instruments.com/en/products/traktor/dj-controllers/traktor-kontrol-s4/>` |
There was a problem hiding this comment.
I think the __ are required to make this appear like a link
https://deploy-preview-652--mixxx-manual.netlify.app/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.html
There was a problem hiding this comment.
ah, didn't realize I'd removed that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this I would like to make a change to the way the mapping details are described. I am going to first describe what combination of buttons are held or actions are performed, then describe the effect. As written it is very confusing