Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Numark Mixtrack Platinum FX #623

Open
wants to merge 93 commits into
base: 2.4
Choose a base branch
from
Open

Manual Numark Mixtrack Platinum FX #623

wants to merge 93 commits into from

Conversation

evoixmr
Copy link

@evoixmr evoixmr commented Feb 26, 2024

@ronso0 ronso0 marked this pull request as draft February 27, 2024 09:04
@evoixmr evoixmr changed the title Manual for mapping of Numark Mixtrack Platinum FX Manual Numark Mixtrack Platinum FX Mar 6, 2024
@evoixmr evoixmr marked this pull request as ready for review March 6, 2024 20:05
@ronso0
Copy link
Member

ronso0 commented Mar 7, 2024

Just a quick note regrading the images:
it would be preferred to create rather small SVG overviews instead of adding ~1 MB PNG images to the repo. You can create black/white SVGs by tracing the origial raster image (as you did in an earlier commit I think).
Or adopt an existing SVG, e.g. from the Platinum https://manual.mixxx.org/2.4/en/hardware/controllers/numark_mixtrack_platinum

@evoixmr
Copy link
Author

evoixmr commented Mar 7, 2024

@ronso0 I updated all photos and scripts to use svg. I also deleted the png files.

.. Credit to PopHippy for creating the original PDF file.

Numark Mixtrack Platinum FX

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This blank line before the dash line indicating a header makes the page generator pick Overview as page title.
Please remove.
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated header.

:alt: Numark Mixtrack Playinum FX (schematic view)
:figclass: pretty-figures

---------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---------------
---------------

Please remove these lines. They prevent proper header rendering. Also some table rows are broken due to blank lines.
I suggest you check the preview and tweak until it looks as desired.
https://deploy-preview-623--mixxx-manual.netlify.app/hardware/controllers/numark_mixtrack_platinum_fx

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the lines.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appearance is still broken, just check the preview.
FYI you may also build the html locally with make html and double-check before pushing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the appearance. Can you recheck and make suggestion on which areas need to be improve?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's loking good now. It were just the blank lines that enforced header formatting on each following line.

@evoixmr evoixmr requested a review from ronso0 October 20, 2024 14:51
@ronso0
Copy link
Member

ronso0 commented Oct 21, 2024

Thanks for the reminder @evoixmr
It looks like work/review on mixxxdj/mixxx#12872 has stalled, but this PR is mostly ready?
What do you think about effect toggles

Press one of these buttons to select a software effect.
• HPF (High pass filter)
• LPF (Low pass filter)
• Flanger
• Echo
• Reverb
• Phaser

IIUC work on this mapping started while 2.3 was the stable version, and 2.4 now allows to load specific effect presets (ie. items at specific position in the preset list, not by effect uuid or something).
Does it make sense to address this now?

@evoixmr
Copy link
Author

evoixmr commented Oct 30, 2024

Thanks for the reminder @evoixmr It looks like work/review on mixxxdj/mixxx#12872 has stalled, but this PR is mostly ready? What do you think about effect toggles

Press one of these buttons to select a software effect.
• HPF (High pass filter)
• LPF (Low pass filter)
• Flanger
• Echo
• Reverb
• Phaser

IIUC work on this mapping started while 2.3 was the stable version, and 2.4 now allows to load specific effect presets (ie. items at specific position in the preset list, not by effect uuid or something). Does it make sense to address this now?

Yes, the PR is ready. As far as he effects preset, is there a documentation that I can use to add preset?

@ronso0
Copy link
Member

ronso0 commented Oct 30, 2024

All effect / effect chain preset controls are documented here
https://manual.mixxx.org/2.4/en/chapters/appendix/mixxx_controls.html#controls

Loading specific Quick Effect presets can be done with [QuickEffectRack1_[ChannelI]],loaded_chain_preset.
This control expects an integer argument 0 .. [num_chain_presets - 1], so the user has to arrange the Quick Effect presets in Preferences -> Effects to match the button labels (or any desired custom mapping).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants