Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Web Sockets #145

Open
twwwt opened this issue Jul 3, 2018 · 4 comments
Open

Support for Web Sockets #145

twwwt opened this issue Jul 3, 2018 · 4 comments
Labels

Comments

@twwwt
Copy link
Contributor

twwwt commented Jul 3, 2018

I'm wondering whether the proxy servlet supports Web Sockets? I think the important thing is that it must not remove the headers Upgrade: WebSocket and Connection: Upgrade.

@dsmiley
Copy link
Collaborator

dsmiley commented Jul 3, 2018

I don't know; but if you try it out then please support back. The proxy generally copies all headers on through.

@geezer78
Copy link

Has anyone got this proxy servlet working with websockets (i use socket.io)? to my understanding it needs more than "just" pushing the hop-hop headers to the backend, i think you might need to create an actual socket tunnel?
can anyone shed some light on this?

@geezer78
Copy link

I see that akarnokd has done some work on adding proxy support see stackoverflow

i've tested this and it seems to work. could we incorporate this functionality?

@dsmiley
Copy link
Collaborator

dsmiley commented Apr 16, 2024

As the maintainer here, mainly I want to see that what we add is tested. That's a key aspect to this proxy vs code snippets on Stackoverflow/blogs. So if you look at that and find a way to incorporate it and add tests, I'd be happy to peer review and ultimately merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants