Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: improve mobile drawers #1229

Open
HussainTaj-arbisoft opened this issue Aug 23, 2023 · 0 comments
Open

Accessibility: improve mobile drawers #1229

HussainTaj-arbisoft opened this issue Aug 23, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@HussainTaj-arbisoft
Copy link
Contributor

In mobile view, our drawers are "hidden" by moving them off of the screen. The drawers are not "display: none" or removed from the DOM (or accessibility tree). This causes the screen readers to perceive them.

There are two drawers, the one on the left with the outline and the one on the right with the course info.

Please take a look at the video for reference.

reference.mp4

Expected Behavior

On mobile, screen readers should not read the drawer content until it is opened and in view.

Current Behavior

On mobile, screen readers read the content of the drawers when the drawers are not in view.

Steps to Reproduce

  1. Open any course page with the drawers.
  2. Read the entire screen with your screen reader assistant.

Possible Solution

There are many ways to hide content from screen readers.

In general, we would have to rewrite the drawer toggle and animation logic.

We can either use: display: none, aria-hidden="true", or remove the drawers from DOM when they are not in view.

@HussainTaj-arbisoft HussainTaj-arbisoft added the bug Something isn't working label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant