Skip to content

Commit 15f63d0

Browse files
[CI] Adjust Windows opam config for ocaml/setup-ocaml 3 (#1939)
* Update coq-windows.yml: remove depext and sunset repo * Update coq-windows.yml: pin ocamlfind fix * Update coq-windows.yml * use opam conf-time to install Windows depa setup-ocaml no longer exposes cygwin * pin upstream ocamlfind * Update coq-windows.yml * Don't indirect through bash * Update coq-opam-package.yml --------- Co-authored-by: Jason Gross <[email protected]>
1 parent 23e42a9 commit 15f63d0

File tree

2 files changed

+8
-22
lines changed

2 files changed

+8
-22
lines changed

.github/workflows/coq-opam-package.yml

+5-8
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,19 @@ jobs:
2121
runs-on: 'ubuntu-latest',
2222
ocaml-compiler: '4.09.1',
2323
coq-extra-flags: '',
24-
extra-ocaml-repositories: '',
24+
ocamlfind-pin: '',
2525
opam-jobs-flag: ''},
2626
{name: 'macOS',
2727
runs-on: 'macos-latest',
2828
ocaml-compiler: '4.14.2',
2929
coq-extra-flags: '',
30-
extra-ocaml-repositories: '',
30+
ocamlfind-pin: '',
3131
opam-jobs-flag: ''},
3232
{name: 'Windows',
3333
runs-on: 'windows-latest',
3434
ocaml-compiler: '4.13.1',
3535
coq-extra-flags: '-async-proofs-j 1',
36-
extra-ocaml-repositories: 'opam-repository-mingw: https://github.com/ocaml-opam/opam-repository-mingw.git#sunset',
36+
ocamlfind-pin: 'git+https://github.com/ocaml/ocamlfind.git#master',
3737
opam-jobs-flag: '-j 1'}]
3838

3939
runs-on: ${{ matrix.os.runs-on }}
@@ -47,9 +47,6 @@ jobs:
4747
uses: ocaml/setup-ocaml@v3
4848
with:
4949
ocaml-compiler: ${{ matrix.os.ocaml-compiler }}
50-
opam-repositories: |-
51-
${{ matrix.os.extra-ocaml-repositories }}
52-
default: https://github.com/ocaml/opam-repository.git
5350

5451
- name: echo Linux build params
5552
run: |
@@ -114,7 +111,8 @@ jobs:
114111
- run: opam repo add coq-released https://coq.inria.fr/opam/released
115112
- run: opam repo add coq-extra-dev https://coq.inria.fr/opam/extra-dev
116113
- run: opam update
117-
- run: opam depext coq.${{ matrix.coq-version }}
114+
- run: opam pin add ocamlfind '${{ matrix.os.ocamlfind-pin }}'
115+
if: matrix.os.ocamlfind-pin != ''
118116
- run: opam pin --kind=version add coq ${{ matrix.coq-version }}
119117

120118
- name: echo more build params
@@ -132,7 +130,6 @@ jobs:
132130
echo "" | opam exec -- coqtop
133131
echo ::endgroup::
134132
135-
- run: opam exec -- opam-depext coq-fiat-crypto
136133
- run: opam install coq-fiat-crypto --with-test ${{ matrix.os.opam-jobs-flag }}
137134
env:
138135
COQEXTRAFLAGS: ${{ matrix.os.coq-extra-flags }}

.github/workflows/coq-windows.yml

+3-14
Original file line numberDiff line numberDiff line change
@@ -44,23 +44,12 @@ jobs:
4444
uses: ocaml/setup-ocaml@v3
4545
with:
4646
ocaml-compiler: 4.13.1
47-
opam-repositories: |
48-
opam-repository-mingw: https://github.com/ocaml-opam/opam-repository-mingw.git#sunset
49-
default: https://github.com/ocaml/opam-repository.git
50-
- run: opam depext coq.${{ env.COQ_VERSION }}
47+
- run: opam pin add ocamlfind 'git+https://github.com/ocaml/ocamlfind.git#master'
5148
- run: opam pin add --kind=version coq ${{ env.COQ_VERSION }}
5249
- run: opam install js_of_ocaml
53-
54-
- name: Install System Dependencies
55-
run: |
56-
%CYGWIN_ROOT%\setup-x86_64.exe -qnNdO -P time,zip
57-
shell: cmd
58-
50+
- run: opam install conf-time
5951
- name: Work around https://github.com/actions/checkout/issues/766
60-
run: |
61-
%CYGWIN_ROOT%\bin\bash.exe -l -c 'git config --global --add safe.directory "*"'
62-
shell: cmd
63-
52+
run: opam exec -- git config --global --add safe.directory "*"
6453
- name: echo build params
6554
run: .\etc\ci\describe-system-config-win.ps1
6655
- name: deps

0 commit comments

Comments
 (0)