enhance: AVIF support #9281

tamaina · 2022-12-05T12:46:30Z

Resolve #9275

What

AVIFをプレビューするように

saschanaz · 2022-12-05T12:56:13Z

Tests have been failing for some time, is there a tracking issue for that?

tamaina · 2022-12-05T12:58:28Z

#9230 ?

tamaina · 2022-12-05T13:00:03Z

いや違うな

tamaina · 2022-12-05T14:10:02Z

これじゃ完全じゃないのか

saschanaz · 2022-12-05T14:15:39Z

まだlinterエラー何個かありますね

…as-browsersafe

tamaina · 2022-12-05T14:21:16Z

linterエラーは今回は無視で…

saschanaz · 2022-12-05T14:28:30Z

FAIL test/unit/MetaService.ts
  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (../../node_modules/.store/@jest-core-virtual-2ac1eab308/node_modules/@jest/core/build/TestScheduler.js:133:18)
      at ../../node_modules/.store/emittery-npm-0.13.1-cb6cd1bb03/node_modules/emittery/index.js:363:13
          at Array.map (<anonymous>)
      at Emittery.emit (../../node_modules/.store/emittery-npm-0.13.1-cb6cd1bb03/node_modules/emittery/index.js:361:23)

あのテストは削除して後で再び追加した方がいいかもです

tamaina · 2022-12-05T14:47:01Z

p1.a9z.devで動作中

tamaina · 2022-12-06T06:52:53Z

/deploy sha=31ac457

github-actions · 2022-12-06T07:04:09Z

Your preview environment pr-9281-syuilo has been deployed.

Preview environment endpoint is available here

tamaina · 2022-12-06T07:17:54Z

503吐いてる

syuilo · 2022-12-06T07:19:20Z

misskey-7b9f68b76f-jdv6rmisskey> yarn migrate && yarn start
misskey-7b9f68b76f-jdv6rmisskey
misskey-7b9f68b76f-jdv6rmisskeyUsage Error: The project in /misskey/package.json doesn't seem to have been installed - running an install there might help
misskey-7b9f68b76f-jdv6rmisskey

tamaina · 2022-12-06T07:55:39Z

ちょっと今すぐにはよくわからない
（Dockerfileで各ワークスペースのnode_modulesをコピーしてないのが原因…？

tamaina · 2022-12-06T19:45:54Z

#9281 (comment) → #9291

tamaina · 2022-12-07T18:19:00Z

/deploy sha=0037850

tamaina · 2022-12-07T18:41:10Z

やっぱダメそう？

tamaina · 2022-12-07T22:32:52Z

/deploy sha=cb3c032

tamaina · 2022-12-07T22:48:06Z

/deploy sha=4c8587d

tamaina · 2022-12-07T23:02:04Z

どう @syuilo

syuilo · 2022-12-07T23:06:48Z

起動処理がまだ途中

syuilo · 2022-12-07T23:07:39Z

misskey-565cf54667-tspzrmisskeyDONE * [core boot] All workers started
misskey-565cf54667-tspzrmisskeyDONE * [core boot] Now listening on port 3000 on https://misskey-pr-9281-syuilo.cloud.okteto.net/

syuilo · 2022-12-07T23:08:55Z

misskey-565cf54667-tspzrmisskey[ioredis] Unhandled error event: Error: connect ETIMEDOUT
misskey-565cf54667-tspzrmisskey at Socket.<anonymous> (/misskey/node_modules/.store/ioredis-npm-4.28.5-74671f2fa3/node_modules/ioredis/built/redis/index.js:327:37)
misskey-565cf54667-tspzrmisskey at Object.onceWrapper (node:events:627:28)
misskey-565cf54667-tspzrmisskey at Socket.emit (node:events:513:28)
misskey-565cf54667-tspzrmisskey at Socket.emit (node:domain:489:12)
misskey-565cf54667-tspzrmisskey at Socket._onTimeout (node:net:562:8)
misskey-565cf54667-tspzrmisskey at listOnTimeout (node:internal/timers:564:17)
misskey-565cf54667-tspzrmisskey at process.processTimers (node:internal/timers:507:7)
misskey-565cf54667-tspzrmisskeyERR 1 [queue system] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue deliver] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue inbox] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue db] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue objectStorage] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue webhook] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue deliver] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue inbox] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue webhook] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue db] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue objectStorage] error undefined
misskey-565cf54667-tspzrmisskeyERR 1 [queue system] error undefined

misskey-565cf54667-tspzrmisskeyERR 1 [server] Error: bind EADDRNOTAVAIL 35.225.69.73:3000
misskey-565cf54667-tspzrmisskeyError: bind EADDRNOTAVAIL 35.225.69.73:3000
misskey-565cf54667-tspzrmisskey at listenOnPrimaryHandle (node:net:1553:18)
misskey-565cf54667-tspzrmisskey at rr (node:internal/cluster/child:159:12)
misskey-565cf54667-tspzrmisskey at Worker.<anonymous> (node:internal/cluster/child:109:7)
misskey-565cf54667-tspzrmisskey at process.onInternalMessage (node:internal/cluster/utils:49:5)
misskey-565cf54667-tspzrmisskey at process.emit (node:events:525:35)
misskey-565cf54667-tspzrmisskey at process.emit (node:domain:489:12)
misskey-565cf54667-tspzrmisskey at emit (node:internal/child_process:937:14)
misskey-565cf54667-tspzrmisskey at process.processTicksAndRejections (node:internal/process/task_queues:83:21) {
misskey-565cf54667-tspzrmisskey errno: -99,
misskey-565cf54667-tspzrmisskey code: 'EADDRNOTAVAIL',
misskey-565cf54667-tspzrmisskey syscall: 'bind',
misskey-565cf54667-tspzrmisskey address: '35.225.69.73',
misskey-565cf54667-tspzrmisskey port: 3000
misskey-565cf54667-tspzrmisskey}
misskey-565cf54667-tspzrmisskeyERR * [core boot] The server Listen failed due to the previous error.
misskey-565cf54667-tspzrmisskeyINFO * [core] The process is going to exit with code 1

tamaina · 2022-12-07T23:42:03Z

うーんさっぱりわからん

ikuradon · 2022-12-08T01:14:33Z

Oktetoが動かないのでとりあえず手元クラスタで動かしてみたんですけど、多分これurlのドメイン部分を正引きしたアドレスでbindしようとしてますね…
url: https://google.comにしてみたとき

[Nest] 90  - 12/08/2022, 1:13:25 AM     LOG [InstanceLoader] CoreModule dependencies initialized +6ms
INFO *	[db sql]	DELETE FROM "attestation_challenge" WHERE "createdAt" < $1
ERR  1	[server]	Error: bind EADDRNOTAVAIL 2404:6800:4004:821::200e:3000
ERR  *	[core boot]	The server Listen failed due to the previous error.
INFO *	[core]	The process is going to exit with code 1
Error: bind EADDRNOTAVAIL 2404:6800:4004:821::200e:3000
    at listenOnPrimaryHandle (node:net:1553:18)
    at rr (node:internal/cluster/child:159:12)
    at Worker.<anonymous> (node:internal/cluster/child:109:7)
    at process.onInternalMessage (node:internal/cluster/utils:49:5)
    at process.emit (node:events:525:35)
    at process.emit (node:domain:489:12)
    at emit (node:internal/child_process:937:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -99,
  code: 'EADDRNOTAVAIL',
  syscall: 'bind',
  address: '2404:6800:4004:821::200e',
  port: 3000
}
INFO 1	[core]	The process is going to exit with code 0

ikuradon · 2022-12-08T01:34:18Z

https://github.com/tamaina/misskey/blob/avif-as-browsersafe/packages/backend/src/server/ServerService.ts#L153
https://github.com/tamaina/misskey/blob/avif-as-browsersafe/packages/backend/src/config.ts#L120-L136
あっ…

syuilo · 2022-12-08T04:45:27Z

/deploy sha=f1a82a6

syuilo · 2022-12-08T04:51:52Z

0.0.0.0でも

tspzrmisskeyError: bind EADDRNOTAVAIL 35.225.69.73:3000
misskey-565cf54667-tspzrmisskey at listenOnPrimaryHandle (node:net:1553:18)
misskey-565cf54667-tspzrmisskey at rr (node:internal/cluster/child:159:12)
misskey-565cf54667-tspzrmisskey at Worker.<anonymous> (node:internal/cluster/child:109:7)
misskey-565cf54667-tspzrmisskey at process.onInternalMessage (node:internal/cluster/utils:49:5)
misskey-565cf54667-tspzrmisskey at process.emit (node:events:525:35)
misskey-565cf54667-tspzrmisskey at process.emit (node:domain:489:12)
misskey-565cf54667-tspzrmisskey at emit (node:internal/child_process:937:14)
misskey-565cf54667-tspzrmisskey at process.processTicksAndRejections (node:internal/process/task_queues:83:21) {
misskey-565cf54667-tspzrmisskey errno: -99,
misskey-565cf54667-tspzrmisskey code: 'EADDRNOTAVAIL',
misskey-565cf54667-tspzrmisskey syscall: 'bind',
misskey-565cf54667-tspzrmisskey address: '35.225.69.73',
misskey-565cf54667-tspzrmisskey port: 3000
misskey-565cf54667-tspzrmisskey}

が出る

syuilo · 2022-12-08T04:54:47Z

いや適用前でデプロイされてただけかも

syuilo · 2022-12-08T04:55:08Z

なんか今またデプロイ走ってる

syuilo · 2022-12-08T04:58:39Z

動いたわ
https://misskey-pr-9281-syuilo.cloud.okteto.net/

syuilo · 2022-12-08T04:59:06Z

Redisのエラーは相変わらず出てるけど

misskey-79cdc799bc-89bc6misskey[ioredis] Unhandled error event: Error: connect ETIMEDOUT
misskey-79cdc799bc-89bc6misskey at Socket.<anonymous> (/misskey/node_modules/.store/ioredis-npm-4.28.5-74671f2fa3/node_modules/ioredis/built/redis/index.js:327:37)
misskey-79cdc799bc-89bc6misskey at Object.onceWrapper (node:events:627:28)
misskey-79cdc799bc-89bc6misskey at Socket.emit (node:events:513:28)
misskey-79cdc799bc-89bc6misskey at Socket.emit (node:domain:489:12)
misskey-79cdc799bc-89bc6misskey at Socket._onTimeout (node:net:562:8)
misskey-79cdc799bc-89bc6misskey at listOnTimeout (node:internal/timers:564:17)

syuilo · 2022-12-08T05:02:03Z

Redisエラー出てるわりには普通にストリーミング動いてる

syuilo · 2022-12-08T05:05:59Z

無料だからしょうがないけどCPUが貧弱

syuilo · 2022-12-08T05:10:33Z

連合するとあまたのインスタンスから照会リクエスト飛んできてCPU使い切って実質死ぬわね

syuilo · 2022-12-08T05:11:20Z

無料だからしょうがないけどCPUが貧弱

JSの1行実行するのに10msくらいかかってそう

tamaina · 2022-12-08T05:11:28Z

あっ…申し訳ない…

tamaina · 2022-12-08T05:12:58Z

（OCI A1 4コアでも毎回のdeliverでCPUが100%に跳ね上がっている

syuilo · 2022-12-08T05:15:28Z

これ有料プランにしたらCPUパワーも上がるのかね
ただ無料の次が月額$99で少し高い

syuilo · 2022-12-08T05:16:44Z

https://www.okteto.com/pricing/ だと$99になってるけど管理画面で見ると$149となっていてどっちなのか分からない
(いずれにしても高い)

tamaina · 2022-12-08T05:17:36Z

3万ぐらいの自宅サーバーで頑張ったほうが安上がり？同じようなソリューションがあるかは知らない

CyberRex0 · 2022-12-08T05:22:30Z

JetBrainsのTeamCityで自家CD/CIできるかも
無料で使える
https://www.jetbrains.com/ja-jp/teamcity/
https://www.jetbrains.com/ja-jp/teamcity/features/vcs_interoperability.html
https://www.jetbrains.com/help/teamcity/integrating-teamcity-with-vcs-hosting-services.html

* chore: Make image/avif browsersafe * server side * change FileInfoService * ✌️ * avifはMastodonでは絶望的 see misskey-dev#9283 Co-authored-by: syuilo <[email protected]> Co-authored-by: tamaina <[email protected]>

chore: Make image/avif browsersafe

cd91a44

github-actions bot added the packages/frontend Client side specific issue/PR label Dec 5, 2022

server side

be9f4f4

tamaina requested a review from syuilo December 5, 2022 12:48

tamaina marked this pull request as ready for review December 5, 2022 12:48

github-actions bot added the packages/backend Server side specific issue/PR label Dec 5, 2022

Merge branch 'misskey-dev:develop' into avif-as-browsersafe

c93da57

tamaina added 2 commits December 5, 2022 14:19

change FileInfoService

600741d

Merge remote-tracking branch 'tamaina/avif-as-browsersafe' into avif-…

4633901

…as-browsersafe

✌️

10025b7

avifはMastodonでは絶望的 see misskey-dev#9283

b73ee90

tamaina changed the title ~~chore: Make image/avif browsersafe~~ enhance: AVIF support Dec 5, 2022

Merge branch 'misskey-dev:develop' into avif-as-browsersafe

31ac457

Merge branch 'misskey-dev:develop' into avif-as-browsersafe

0037850

Merge branch 'misskey-dev:develop' into avif-as-browsersafe

cb3c032

Merge branch 'misskey-dev:develop' into avif-as-browsersafe

4c8587d

Merge branch 'develop' into pr/9281

f1a82a6

syuilo merged commit e81c296 into misskey-dev:develop Dec 8, 2022

enhance: AVIF support #9281

enhance: AVIF support #9281

Conversation

tamaina commented Dec 5, 2022

What

saschanaz commented Dec 5, 2022

tamaina commented Dec 5, 2022

tamaina commented Dec 5, 2022

tamaina commented Dec 5, 2022

saschanaz commented Dec 5, 2022

tamaina commented Dec 5, 2022

saschanaz commented Dec 5, 2022

tamaina commented Dec 5, 2022

tamaina commented Dec 6, 2022

github-actions bot commented Dec 6, 2022

tamaina commented Dec 6, 2022

syuilo commented Dec 6, 2022

tamaina commented Dec 6, 2022

tamaina commented Dec 6, 2022

tamaina commented Dec 7, 2022

tamaina commented Dec 7, 2022

tamaina commented Dec 7, 2022

tamaina commented Dec 7, 2022

tamaina commented Dec 7, 2022

syuilo commented Dec 7, 2022

syuilo commented Dec 7, 2022

syuilo commented Dec 7, 2022 • edited Loading

tamaina commented Dec 7, 2022

ikuradon commented Dec 8, 2022

ikuradon commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022

tamaina commented Dec 8, 2022

tamaina commented Dec 8, 2022

syuilo commented Dec 8, 2022

syuilo commented Dec 8, 2022 • edited Loading

tamaina commented Dec 8, 2022

CyberRex0 commented Dec 8, 2022 • edited Loading

syuilo commented Dec 7, 2022 •

edited

Loading

syuilo commented Dec 8, 2022 •

edited

Loading

CyberRex0 commented Dec 8, 2022 •

edited

Loading