Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: SystemWebhook/UserWebhookの配信処理呼び出し部分の改善 #15035

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

samunohito
Copy link
Member

@samunohito samunohito commented Nov 23, 2024

What

タイトルの通りです。QueueServiceに登録する処理をSystemWebhookService/UserWebhookServiceへ寄せました。

Why

fix: #15003

Additional info (optional)

  • 既存のunittestを実行してfailにならないことを確認
  • 新たにunittestを追加して確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md ※実動作は変わらないので記載なし
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Nov 23, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 89.85507% with 7 lines in your changes missing coverage. Please review.

Project coverage is 39.99%. Comparing base (a3d236c) to head (198cdc2).
Report is 450 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/NoteCreateService.ts 0.00% 4 Missing ⚠️
packages/backend/src/core/UserBlockingService.ts 0.00% 1 Missing ⚠️
packages/backend/src/core/UserFollowingService.ts 75.00% 1 Missing ⚠️
packages/backend/src/core/UserService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15035      +/-   ##
===========================================
- Coverage    41.74%   39.99%   -1.75%     
===========================================
  Files         1549     1563      +14     
  Lines       196555   197681    +1126     
  Branches      2767     3642     +875     
===========================================
- Hits         82055    79072    -2983     
- Misses      113939   118004    +4065     
- Partials       561      605      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 23, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@samunohito samunohito marked this pull request as ready for review November 23, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] UserWebhookの配信処理をService化
1 participant