Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: stats apiの重い処理をスキップできるように #15062

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

リアクションカウントのぶぶんをスキップして/stats APIを返せるようにした

Why

#4880 (comment)
(根本解決ではないが、暫定対応としてはこれで十分かと)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Nov 26, 2024
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -401,6 +401,9 @@
                     "enableServerMachineStats": {
                       "type": "boolean"
                     },
+                    "enableEnhancedServerStats": {
+                      "type": "boolean"
+                    },
                     "enableIdenticonGeneration": {
                       "type": "boolean"
                     },
@@ -654,6 +657,7 @@
                     "enableChartsForFederatedInstances",
                     "enableStatsForFederatedInstances",
                     "enableServerMachineStats",
+                    "enableEnhancedServerStats",
                     "enableIdenticonGeneration",
                     "manifestJsonOverride",
                     "policies",
@@ -14288,6 +14292,9 @@
                   "enableServerMachineStats": {
                     "type": "boolean"
                   },
+                  "enableEnhancedServerStats": {
+                    "type": "boolean"
+                  },
                   "enableIdenticonGeneration": {
                     "type": "boolean"
                   },

Get diff files from Workflow Page

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 30.55556% with 25 lines in your changes missing coverage. Please review.

Project coverage is 39.96%. Comparing base (a77ad7a) to head (43ac9fc).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/performance.vue 0.00% 16 Missing ⚠️
...kend/src/server/api/endpoints/admin/update-meta.ts 20.00% 4 Missing ⚠️
packages/backend/src/server/api/endpoints/stats.ts 20.00% 4 Missing ⚠️
...ges/backend/src/server/api/endpoints/admin/meta.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15062      +/-   ##
===========================================
- Coverage    39.96%   39.96%   -0.01%     
===========================================
  Files         1563     1563              
  Lines       197744   197778      +34     
  Branches      3631     3632       +1     
===========================================
+ Hits         79027    79034       +7     
- Misses      118112   118139      +27     
  Partials       605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant