Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 画面サイズが変わった際にnavbarが自動で折りたたまれない問題を修正 #15042

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

画面幅の評価をウィンドウのリサイズ時にも行うように
(起動時の1度だけしか評価されないようになっていたため)

Why

Fix #14983 (comment)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 23, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 19.14%. Comparing base (04b2214) to head (10ed8b0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/ui/_common_/navbar.vue 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15042       +/-   ##
============================================
- Coverage    39.95%   19.14%   -20.81%     
============================================
  Files         1563      728      -835     
  Lines       197739   103800    -93939     
  Branches      3625      993     -2632     
============================================
- Hits         79012    19876    -59136     
+ Misses      118154    83368    -34786     
+ Partials       573      556       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@samunohito samunohito added this to the v2024.11.1? milestone Nov 23, 2024
@syuilo syuilo merged commit d91a1be into misskey-dev:develop Nov 23, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 23, 2024

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the fix-14983 branch November 23, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants