Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(frontend): reduce api requests for non-logged-in enviroment #15001

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Nov 19, 2024

What

Resolve #14805

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 39.92%. Comparing base (7b9c884) to head (ec73511).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/server-context.ts 0.00% 22 Missing and 1 partial ⚠️
...ages/backend/src/server/web/ClientServerService.ts 0.00% 13 Missing ⚠️
packages/frontend/src/pages/note.vue 0.00% 8 Missing ⚠️
packages/frontend/src/pages/clip.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15001      +/-   ##
===========================================
- Coverage    39.97%   39.92%   -0.05%     
===========================================
  Files         1561     1562       +1     
  Lines       197358   197406      +48     
  Branches      3609     3606       -3     
===========================================
- Hits         78888    78817      -71     
- Misses      117864   118015     +151     
+ Partials       606      574      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@syuilo syuilo marked this pull request as ready for review November 20, 2024 12:08
@syuilo syuilo merged commit f0c3a4c into develop Nov 20, 2024
32 checks passed
@syuilo syuilo deleted the 14805 branch November 20, 2024 22:58
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

非embedでもデータを予め準備しておく
1 participant