New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GitHub Enterprise #268

Open

bn-d opened this issue Nov 9, 2022 · 1 comment

bn-d commented Nov 9, 2022 •

edited

Loading

Currently the host and scheme is hard coded at

ocaml-github/lib/github_core.ml

Line 177 in 91edfae

let entry_uri = "https://github.com/login/oauth/authorize" in

I would be great if we can add support for GitHub Enterprise Server.

i.e.

let authorize
  ?(scheme="https")
  ?(host="github.com")
  ...
  =
  ...
  Uri.make ~scheme ~host ~path:"login/oauth/access_token" ~query ()

Member

tmcgilchrist commented Jan 11, 2023

👍🏻 PRs very welcome to do this.

A good place to start would be extending Github_s.Env to include this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment