Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check empty stream endpoints for 404 compatibility #119

Open
dsheets opened this issue May 25, 2016 · 1 comment
Open

Check empty stream endpoints for 404 compatibility #119

dsheets opened this issue May 25, 2016 · 1 comment

Comments

@dsheets
Copy link
Member

dsheets commented May 25, 2016

#113 points out that some stream endpoints can be empty and, when they are, the API returns 404. We should check the various stream endpoints for this behavior (or find reference in GitHub's docs about it) and then handle it appropriately.

@dsheets
Copy link
Member Author

dsheets commented Nov 26, 2016

This should really apply to all endpoints that can result in 404 because the object is missing or inaccessible. The functions which bind these endpoints should return an option or an 'a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant