Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The cold wallet can have better compile-time guarantees #1499

Open
TheQuantumPhysicist opened this issue Jan 25, 2024 · 0 comments
Open

The cold wallet can have better compile-time guarantees #1499

TheQuantumPhysicist opened this issue Jan 25, 2024 · 0 comments
Labels
wallet Everything related to the node wallets (whether GUI or CLI) wallet-cli
Milestone
Phase Alpha

Comments

@TheQuantumPhysicist
Copy link
Contributor

As discussed in #1497, ideally, the ColdWalletClient doesn't implement the NodeInterface at all, but in the NodeController, only the methods that require communication with the node would require NodeInterface.
@TheQuantumPhysicist TheQuantumPhysicist added wallet Everything related to the node wallets (whether GUI or CLI) wallet-cli labels Jan 25, 2024
@TheQuantumPhysicist TheQuantumPhysicist added this to the Phase Alpha milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wallet Everything related to the node wallets (whether GUI or CLI) wallet-cli
Projects
None yet
Milestone
Phase Alpha
Development

No branches or pull requests
1 participant
@TheQuantumPhysicist