fix(scss): amend sass loadpaths to include node_modules directory #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove the node modules prefix from the govuk scss import in all.scss. Which would resolve loading issues for users. BREAKING CHANGE: This PR changes the loadpath for govuk frontend. You will now need to ensure your project SASS configuration includes node_modules within its loadpaths in order to compile, however this is often default behaviour in many build tools. fix #927
chrispymm
added
bug
|
Hi, there is one module that also use node_modules - cookie_banner. It would be nice to fix that one at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove the node modules prefix from the govuk scss import in all.scss. Which would resolve loading issues for users.
BREAKING CHANGE: This PR changes the loadpath for govuk frontend. You will now need to ensure your project SASS configuration includes node_modules within its loadpaths in order to compile, however this is often default behaviour in many build tools.
fix #927