Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crafting recipe of rope segment collides with ethereal paper recipe #21

Open
Bastrabun opened this issue Jul 8, 2020 · 0 comments
Open

Comments

@Bastrabun
Copy link

Bastrabun commented Jul 8, 2020

Unfortunately the crafting recipe of 2x3 cotton to make a rope segment collides with ethereal's to make paper:

https://notabug.org/TenPlus1/ethereal/src/master/extra.lua, line 112:

-- Paper (2x3 string = 4 paper)
minetest.register_craft({
	output = "default:paper 4",
	recipe = {
		{"farming:cotton", "farming:cotton"},
		{"farming:cotton", "farming:cotton"},
		{"farming:cotton", "farming:cotton"},
	}
})

On my server I changed your https://github.com/minetest-mods/ropes/blob/master/crafts.lua to

if minetest.get_modpath("farming") then
-- this doesn't work reliably due to side effects of https://github.com/minetest/minetest/issues/5518
--	local old_def = minetest.registered_craftitems["farming:cotton"]
--	if old_def then
--		old_def.groups["thread"] = 1
--		minetest.override_item("farming:cotton", {
--			groups = old_def.groups
--		})
--	end
	minetest.register_craft({
		output = 'ropes:ropesegment',
		recipe = {
			{'farming:cotton','farming:cotton','farming:cotton'},
			{'farming:cotton','farming:cotton','farming:cotton'},
		}
	})
end

Not sure whether you or Tenplus1 may want to change theirs. I'll also send him an issue and maybe before BOTH change theirs, check with each other :D

The ethereal issue is here: https://notabug.org/TenPlus1/ethereal/issues/12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant