Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt to new standard of bundle flags [proposed Label] enhancement #714

Open
pebwindkraft opened this issue Oct 19, 2022 · 0 comments · May be fixed by #725
Open

Adopt to new standard of bundle flags [proposed Label] enhancement #714

pebwindkraft opened this issue Oct 19, 2022 · 0 comments · May be fixed by #725

Comments

@pebwindkraft
Copy link

When deploying with mina, bundle shows deprecated flags, which will need to be changed when version 3 rolls in.

[DEPRECATED] The `--deployment` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local deployment 'true'`, and stop using this flag
[DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local path 'vendor/bundle'`, and stop using this flag
[DEPRECATED] The `--without` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local without 'development test'`, and stop using this flag

Doing a "bundle --help config" on a 2.3 bundle version, show in the section "REMEMBERING OPTIONS" simliar wording.
Looking at the file [https://github.com/mina-deploy/mina/blob/master/tasks/mina/bundler.rb], line 8 provides the params.
@jp524 jp524 linked a pull request Jan 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify bundler task to fix deprecation warnings jp524/mina
1 participant
@pebwindkraft