Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove equals sign from filename in add_spl_to_patients.py #7

Open
Vincent-Ustach opened this issue Aug 21, 2024 · 0 comments
Open

Comments

@Vincent-Ustach
Copy link

Vincent-Ustach commented Aug 21, 2024

I noticed that the script add_spl_to_patients.py generates filenames that include an equals sign (=).

spl_matrix_fname = project_config.MY_DATA_DIR / f'{args.save_prefix}_agg={args.agg_type}_spl_matrix.npy'

'mydata_agg=mean_spl_matrix.npy'

While this is technically allowed, I recommend avoiding this character in filenames. There are a few reasons for this, such as cross-platform compatibility, shell and command line confusion, potential for automation conflicts, and readability.

Recommendation: Consider replacing the equals sign with a more neutral character, such as an underscore (_) or a dash (-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant