-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [GoSDK] Refine float point conversion precision loss ut #38097
enhance: [GoSDK] Refine float point conversion precision loss ut #38097
Conversation
Previous PR: milvus-io#37978 This unit test is unable due to dim is a random number. When dim is large enough precision loss will be greater than 0.04 Signed-off-by: Congqi Xia <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@jiangyinzuo: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@congqixia go-sdk check failed, comment |
rerun go-sdk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38097 +/- ##
==========================================
+ Coverage 81.06% 82.92% +1.86%
==========================================
Files 1369 1080 -289
Lines 190967 165483 -25484
==========================================
- Hits 154799 137225 -17574
+ Misses 30680 22760 -7920
- Partials 5488 5498 +10
|
/lgtm |
Previous PR: #37978
This unit test is unable due to dim is a random number. When dim is large enough precision loss will be greater than 0.04