Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [GoSDK] Refine float point conversion precision loss ut #38097

Conversation

congqixia
Copy link
Contributor

Previous PR: #37978

This unit test is unable due to dim is a random number. When dim is large enough precision loss will be greater than 0.04

Previous PR: milvus-io#37978

This unit test is unable due to dim is a random number. When dim is
large enough precision loss will be greater than 0.04

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 29, 2024
@jiangyinzuo
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

@jiangyinzuo: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

mergify bot commented Nov 29, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (9d3035c) to head (1fb51a2).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38097      +/-   ##
==========================================
+ Coverage   81.06%   82.92%   +1.86%     
==========================================
  Files        1369     1080     -289     
  Lines      190967   165483   -25484     
==========================================
- Hits       154799   137225   -17574     
+ Misses      30680    22760    -7920     
- Partials     5488     5498      +10     
Components Coverage Δ
Client 73.67% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.18% <ø> (-0.02%) ⬇️

see 327 files with indirect coverage changes

@smellthemoon
Copy link
Contributor

/lgtm

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 29, 2024
@sre-ci-robot sre-ci-robot merged commit fdea7a7 into milvus-io:master Nov 29, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants