Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: refactor delete mvcc function #38066

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: refactor delete mvcc function #38066

wants to merge 1 commit into from
+688 −402

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Nov 28, 2024

@sre-ci-robot sre-ci-robot added area/compilation size/XL Denotes a PR that changes 500-999 lines. labels Nov 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 28, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Nov 28, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (5e807c3) to head (9632660).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38066       +/-   ##
===========================================
+ Coverage   68.87%   82.92%   +14.05%     
===========================================
  Files         289     1080      +791     
  Lines       25484   165484   +140000     
===========================================
+ Hits        17551   137231   +119680     
- Misses       7933    22753    +14820     
- Partials        0     5500     +5500
Components Coverage Δ
Client 73.67% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.18% <ø> (∅)

see 1369 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the refactor_delete_framework branch 2 times, most recently from 70f6fb9 to 44f06dd Compare November 28, 2024 10:15
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Nov 29, 2024

rerun cpp-unit-test

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Nov 29, 2024

/run-cpu-e2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees
No one assigned
Labels
area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhagnlu @sre-ci-robot