Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Optional (Patch?) results on types which look like Error #338

Open
koloboid opened this issue Oct 20, 2023 · 0 comments
Open

Incorrect Optional (Patch?) results on types which look like Error #338

koloboid opened this issue Oct 20, 2023 · 0 comments

Comments

@koloboid
Copy link

🐞 Bug Report

Describe the bug

Incorrect Optional (Patch?) results on types which look like Error

Reproduce the bug

type A = O.Optional<{ name: string; message: string }, 'some'>;

Expected behavior

A should be like

{ name: string; message: string }

Actual behavior

A is an empty object - {}

Possible Solution

I think it's related to ignoring built-in types in PatchFlat. But I have no competence in toolbelt's internals.

@millsp and co-authors: so many thanks to you for this kit! Everyday tool for years!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant