Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .collectionGroup would be a nice to have these are reasonably common queries now. #99

Open
markjose opened this issue Oct 20, 2020 · 2 comments

Comments

@markjose
Copy link

markjose commented Oct 20, 2020

Firstly, this is a great project it's saved me hours of work. It'd be nice to support .collectionGroup() as these are reasonably common in firebase applications now.

Documentation is here https://firebase.google.com/docs/firestore/query-data/queries#collection-group-query

If you're happy to receive PRs, I'm happy to find time to do the work.

@mikkopaderes
Copy link
Owner

Appreciate the kind words.

Firestore has a good way to do unit tests via their emulator now. This project has just become a test bed for me to try out new and upcoming JavaScript.

e.g. I'm doing a rewrite of this project to try out Typescript and maybe some other emerging JS libraries but I just haven't been able to work on it.

I'll welcome PR to get more features on it provided that they're not Firestore Admin APIs. But I do recommend you check out their emulator as it might get you better support long term.

@markjose
Copy link
Author

markjose commented Oct 21, 2020

OK, I appreciate that. I'm familiar with the Emulators and use them regularly for local development. However, having a CI pipeline install the Emulators on every commit is a bit heavyweight for my needs.

collectionGroup is also a client side API, as well as firebase-admin of course. I have a work around for now, but will see if I can find some time to submit a PR and then you can choose to merge or not. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants