-
Notifications
You must be signed in to change notification settings - Fork 2
It is not working with C# 7.2 #6
Comments
thank you for reporting. I'll check next week if there's an easy fix |
@tiksn , could you provide more details? it works fine on the sample project when I add:
to the csproj file. Tried with latest VS2017 Pro (15.5.2) |
currently 7.2 and latest are the same thing, because currently latest minor version of c# is 7.2 and latest major version (default version) is 7.0, but that might change in near future that is why I am keeping latest in my projects |
Also I will describe my issue with more details because it is purely written and not clear. I have a project which is using DateTimeOffset.Now. With your extension installed it should fail and show an errors. if the c# version of project is default (7.0 currently) it fails (as it should be) and shows errors. Also I installed your extension from my branch (the one that I created PR), it shows errors but lets you run application anyway. Is it by design, or it is a bug? |
I wasn't able to reproduce it, so would be nice if you can figure out the minimum reproduction (and, maybe, update the sample project, so I can take a look)
That's by design of VSIX extensions: dotnet/roslyn#5493 |
When C# version is set to default (7.0 currently) it works and shows compiler errors, but when I am changing it to latest (7.2 currently) it fails.
The text was updated successfully, but these errors were encountered: