Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add the ability to delete/ignore a word #158

Open
saxoncameron opened this issue Jan 27, 2022 · 2 comments
Open

[FEATURE] Add the ability to delete/ignore a word #158

saxoncameron opened this issue Jan 27, 2022 · 2 comments
Labels
enhancement Enhancment of an existing feature idea New or something to think about new feature New feature or request python Involves work in Python requires discussion Either complex, underdeveloped, or possibly contentious templates Involves work on the UI

Comments

@saxoncameron
Copy link
Contributor

Discord user ガリン#4920 reports repeated issues with incorrect readings, a.k.a. parser imperfections. e.g.
image
image

My reply, for context:

I don't think we can fix this. As @bent says, we can look at the output that Mecab (the parser under the hood) uses, but if that's what Mecab gives us, that's what you get I'm afraid. Like the parser in the browser extension, it's never going to be 100% perfect
then can you add the option to hide/ignore wrong words

An on-hover icon UI for vocab words would be a great compromise for the expected imperfections of the parser. And would eventually complement the "star" system we have planned as a future feature (#114). I think this is higher priority than a starring system, though.

Implementation considerations

  • How/where do we store the data, regarding which words have been deleted/ignored?
  • What do we "do" with deleted/ignored words? Perhaps it might be best to move them to the end of the vocab word queue, in a collapsed section, so that they can be viewed/restored. Lest we have to figure out how to reset that kind of data.
@saxoncameron saxoncameron added enhancement Enhancment of an existing feature new feature New feature or request requires discussion Either complex, underdeveloped, or possibly contentious idea New or something to think about python Involves work in Python templates Involves work on the UI labels Jan 27, 2022
@saxoncameron
Copy link
Contributor Author

I envision this as an on-hover icon UI, perhaps as one of three actions, including:

@RicBent
Copy link
Contributor

RicBent commented Jan 27, 2022

Assuming all these features would be tied to specific kanji (and not across multiple) the background implementation for this would be pretty simple:

I'd just expose lists like these to the JS context:

words_ignored: [[word1_kanji, word1_reading], [word2_kanji, word2_reading], ...]]
words_starred: [[word1_kanji, word1_reading], [word2_kanji, word2_reading], ...]],
words_edited: [[word1_kanji, word1_reading, word1_reading_edited], [word2_kanji, word2_reading, word2_reading_edited], ...]],

Additionally, I'd expose bridge commands that take the modified lists and save them back to the db.

I'm all for implementing these features, however, I don't think we should touch further features on the JS side before doing #65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancment of an existing feature idea New or something to think about new feature New feature or request python Involves work in Python requires discussion Either complex, underdeveloped, or possibly contentious templates Involves work on the UI
Projects
None yet
Development

No branches or pull requests

2 participants