Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only test coverage against latest stable go #775

Closed
wants to merge 2 commits into from

Conversation

tmthrgd
Copy link
Collaborator

@tmthrgd tmthrgd commented Oct 4, 2018

DO NOT MERGE: This is a work in progress.

The coverage Travis builds are much slower (2x on average) than the non-coverage builds. The coverage results also shouldn't diverge that significantly between go versions.

The coverage Travis builds are much slower (2x on average) than the
non-coverage builds. The coverage results also shouldn't diverge that
significantly between go versions.
@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #775 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
- Coverage   56.88%   56.83%   -0.05%     
==========================================
  Files          42       41       -1     
  Lines       10789    10783       -6     
==========================================
- Hits         6137     6129       -8     
- Misses       3553     3556       +3     
+ Partials     1099     1098       -1
Impacted Files Coverage Δ
msg.go 77.63% <0%> (-0.65%) ⬇️
listen_go_not111.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca2be9...aee98de. Read the comment docs.

@tmthrgd
Copy link
Collaborator Author

tmthrgd commented Oct 4, 2018

go: tip is the slowest build so we're only getting one minute faster with this PR. I'll revisit this once travis-ci/gimme#151 lands which should substantially speed up go: tip.

@tmthrgd tmthrgd closed this Oct 4, 2018
@tmthrgd tmthrgd deleted the travis-cover-some branch October 7, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants